hi -

it has long been that the methods that dereference a const
datavector&lt;t&gt; (operator[], etc), return a `const t*',
even though the value_type is `t*'.

however, datavector&lt;t&gt;::const_iterator has been inconsistent with this,
in that dereferencing the iterator returns a `t*'.

we are trying to change this feature of datavector::const_iterator, so that
dereferencing it will also return a `const t*', consistent with
datavector.  we hope this will help catch instances where
data objects are unintentionally modified.

these changes are in datamodel-00-23-21.
unfortunately, this requires some changes in client packages.

here are the changes in higlobal that were required to be
compatible with these changes.


+verbatim+
index: src/etaphibins.cxx
===================================================================
--- src/etaphibins.cxx	(revision 447210)
+++ src/etaphibins.cxx	(working copy)
@@ -42,7 +42,7 @@
   rec::trackparticlecontainer::const_iterator trackend = tpc-&gt;end();
   for(  ; trackiter!=trackend ; ++trackiter)
     {
-      rec::trackparticle* track = *trackiter;
+      const rec::trackparticle* track = *trackiter;
      //cout &lt;&lt; &quot;track: eta = &quot; &lt;&lt; track-&gt;eta() &lt;&lt; &quot;  phi: &quot; &lt;&lt; track-&gt;phi() &lt;&lt; endl;
       if (track)
 	{
-verbatim-


i also had these changes to fix warnings about unused variables.


+verbatim+
index: src/makepixeltracklets.cxx
===================================================================
--- src/makepixeltracklets.cxx	(revision 447210)
+++ src/makepixeltracklets.cxx	(working copy)
@@ -1172,7 +1172,7 @@
 	  //(*pdgid).push_back((*pitr)-&gt;pdg_id());
 	  (*parttid).push_back((*pitr)-&gt;pdg_id());
 	  
-	  int vbarcode = 0;
+	  //int vbarcode = 0;
 	  if( (*pitr)-&gt;production_vertex() )
 	    {
 	      const hepmc::genvertex *pvrt = (*pitr)-&gt;production_vertex();
@@ -1186,7 +1186,7 @@
 		(*parenttid).push_back((*(pvrt-&gt;particles_in_const_begin()))-&gt;pdg_id());
 	      }
 	      
-	      vbarcode = (*pitr)-&gt;production_vertex()-&gt;barcode();
+	      //vbarcode = (*pitr)-&gt;production_vertex()-&gt;barcode();
 	      //log &lt;&lt; msg::debug &lt;&lt; &quot;vertex barcode: &quot; &lt;&lt; vbarcode &lt;&lt; endreq;
 	      //right now only by position to identify true primary
 	      (*prod_vrtxt).push_back((*pitr)-&gt;production_vertex()-&gt;position().x());
-verbatim-
